Skip to content

Commit

Permalink
Asynchronous I/O latency to a solid-state disk greatly increased betw…
Browse files Browse the repository at this point in the history
…een the 2.6.32 and 3.0 kernels. By removing the plug from do_io_submit(), we observed a 34% improvement in the I/O latency.

Unfortunately, at this level, we don't know if the request is to
a rotating disk or not.

Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: linux-aio@kvack.org
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: umberto1978 <ur.tecnotop@gmail.com>
  • Loading branch information
kleikamp authored and umberto1978 committed Sep 18, 2013
1 parent 054ef00 commit 4b16333
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions fs/aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1618,7 +1618,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
struct kioctx *ctx;
long ret = 0;
int i;
struct blk_plug plug;

if (unlikely(nr < 0))
return -EINVAL;
Expand All @@ -1635,8 +1634,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
return -EINVAL;
}

blk_start_plug(&plug);

/*
* AKPM: should this return a partial result if some of the IOs were
* successfully submitted?
Expand All @@ -1659,7 +1656,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
if (ret)
break;
}
blk_finish_plug(&plug);

put_ioctx(ctx);
return i ? i : ret;
Expand Down

0 comments on commit 4b16333

Please sign in to comment.