Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for img tag helper not outputting alt attribute when specified #59

Merged
merged 4 commits into from
May 5, 2023
Merged

Fix for img tag helper not outputting alt attribute when specified #59

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a60f3ea
If an alt attribute has been added to the image tag helper then we ca…
richarth May 3, 2023
d8ef262
Remove the nested region
May 5, 2023
0a10cb9
Fix the whitespace that did not need changing
May 5, 2023
c88aee3
More fixes to whitespace stuff
May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 10 additions & 3 deletions Our.Umbraco.TagHelpers/ImgTagHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,15 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
height = (originalHeight / originalWidth) * width;
}

#region Autogenerate alt text
#region Autogenerate alt text if unspecfied
if (string.IsNullOrWhiteSpace(ImgAlt))
{
output.Attributes.Add("alt", GetImageAltText(MediaItem));
}
#endregion
else
{
output.Attributes.Add("alt", ImgAlt);
}
#endregion
}
else if (!string.IsNullOrEmpty(FileSource))
Expand All @@ -196,11 +199,15 @@ public override void Process(TagHelperContext context, TagHelperOutput output)

imgSrc = AddQueryToUrl(FileSource, "width", width.ToString());

#region Autogenerate alt text
#region Autogenerate alt text if unspecfied
if (string.IsNullOrWhiteSpace(ImgAlt))
{
output.Attributes.Add("alt", GetImageAltText(FileSource));
}
else
{
output.Attributes.Add("alt", ImgAlt);
}
#endregion

#region If width & height are not defined then return a basic <img> with just a src, alt & class (if provided)
Expand Down