Skip to content

Commit

Permalink
our.umbraco link styling absent on some pages
Browse files Browse the repository at this point in the history
  • Loading branch information
@nul800sebastiaan
nul800sebastiaan committed Apr 28, 2016
1 parent 0b5e452 commit abc7e39
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions OurUmbraco.Client/src/scss/pages/_release.scss
View file
Expand Up @@ -219,10 +219,7 @@
a {
text-decoration: none;

This comment has been minimized.

Sign in to view

Copy link
@bjarnef

bjarnef Apr 28, 2016 •
edited

Contributor

@nul800sebastiaan this line doesn't have any effect as it is overridden later in code.

OurUmbraco/OurUmbraco.Client/src/scss/pages/_release.scss

Lines 219 to 223 in abc7e39

a {
text-decoration: none;
font-family: $font-family;
text-decoration: underline;
}

This comment has been minimized.

Sign in to view

Copy link
@nul800sebastiaan

nul800sebastiaan Apr 28, 2016

Author Member

Works on my machine!

image

This comment has been minimized.

Sign in to view

Copy link
@bjarnef

bjarnef Apr 28, 2016 •
edited

Contributor

@nul800sebastiaan yes, it works.. I just mean this line isn't necessary

OurUmbraco/OurUmbraco.Client/src/scss/pages/_release.scss

Line 220 in abc7e39

text-decoration: none;

or update that line with text-decoration: underline and remove the new added line :)

L222 will always override L220 :)

This comment has been minimized.

Sign in to view

Copy link
@nul800sebastiaan

nul800sebastiaan Apr 28, 2016

Author Member

Duh.. of course lol how redundant.
font-family: $font-family;

&:hover {
text-decoration: underline;
}
text-decoration: underline;
}


Expand Down

0 comments on commit abc7e39

Please sign in to comment.