Form method changed to pass form values as querystring params #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Not sure why we never did this, I think I thought of changing it as soon as we got this feature. Anyway, great job, thanks! It will be deployed soon! |
|
Yup, trivial and I just spotted it as I was in need to share some results from this page. I'm also pretty sure it was working fine at some moment in the past. No matter what - it's nice to help! Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that versions during comparison on https://our.umbraco.org/contribute/releases/compare page are not passed as a query string parameters and the result cannot be easily shared between people.
I thought the whole feature is missing, but I noticed everything is there, but the wrong form method was causing those params to dissapear.
Changing it from POST to GET fixed the problem. Hope it will help others too :)