Skip to content

Commit

Permalink
cleanup TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
Shazwazza committed Jul 30, 2020
1 parent f7a0afb commit 99fc6ef
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 41 deletions.
79 changes: 41 additions & 38 deletions .editorconfig
@@ -1,40 +1,43 @@
# editorconfig.org

# top-most EditorConfig file
root = true

# Default settings:
# A newline ending every file
# Use 4 spaces as indentation
[*]
insert_final_newline = true
end_of_line = crlf
indent_style = space
indent_size = 4

# Trim trailing whitespace, limited support.
# https://github.com/editorconfig/editorconfig/wiki/Property-research:-Trim-trailing-spaces
trim_trailing_whitespace = true

[*.{cs,vb}]
dotnet_style_predefined_type_for_locals_parameters_members = true:error

dotnet_naming_rule.private_members_with_underscore.symbols = private_fields
dotnet_naming_rule.private_members_with_underscore.style = prefix_underscore
dotnet_naming_rule.private_members_with_underscore.severity = suggestion

dotnet_naming_symbols.private_fields.applicable_kinds = field
dotnet_naming_symbols.private_fields.applicable_accessibilities = private

dotnet_naming_style.prefix_underscore.capitalization = camel_case
dotnet_naming_style.prefix_underscore.required_prefix = _

# https://github.com/MicrosoftDocs/visualstudio-docs/blob/master/docs/ide/editorconfig-code-style-settings-reference.md
[*.cs]
csharp_style_var_for_built_in_types = true:suggestion
csharp_style_var_when_type_is_apparent = true:suggestion
csharp_style_var_elsewhere = true:suggestion
# editorconfig.org

# top-most EditorConfig file
root = true

# Default settings:
# A newline ending every file
# Use 4 spaces as indentation
[*]
insert_final_newline = true
end_of_line = crlf
indent_style = space
indent_size = 4

# Trim trailing whitespace, limited support.
# https://github.com/editorconfig/editorconfig/wiki/Property-research:-Trim-trailing-spaces
trim_trailing_whitespace = true

[*.{cs,vb}]
dotnet_style_predefined_type_for_locals_parameters_members = true:error

dotnet_naming_rule.private_members_with_underscore.symbols = private_fields
dotnet_naming_rule.private_members_with_underscore.style = prefix_underscore
dotnet_naming_rule.private_members_with_underscore.severity = suggestion

dotnet_naming_symbols.private_fields.applicable_kinds = field
dotnet_naming_symbols.private_fields.applicable_accessibilities = private

dotnet_naming_style.prefix_underscore.capitalization = camel_case
dotnet_naming_style.prefix_underscore.required_prefix = _

# https://github.com/MicrosoftDocs/visualstudio-docs/blob/master/docs/ide/editorconfig-code-style-settings-reference.md
[*.cs]
csharp_style_var_for_built_in_types = true:suggestion
csharp_style_var_when_type_is_apparent = true:suggestion
csharp_style_var_elsewhere = true:suggestion
csharp_prefer_braces = false : none

[*.{js,less}]

[*.js]
trim_trailing_whitespace = true

[*.less]
trim_trailing_whitespace = false
Expand Up @@ -171,7 +171,6 @@ function valPropertyMsg(serverValidationManager, localizationService, angularHel
// we find all ngModel controls recursively on this form (but stop recursing before we get to the next)
// umbProperty form). Then for each ngModelController we assign a new $validator. This $validator
// will execute whenever the value is changed which allows us to check and reset the server validator
// TODO: Is this even needed?
function startWatch() {
if (!watcher) {

Expand Down
Expand Up @@ -49,7 +49,7 @@ function valServerMatch(serverValidationManager) {

// if we have reached this part, and there is no culture, then lets fallback to invariant. To get the validation feedback for invariant language.
currentCulture = currentCulture || "invariant";

var unsubscribe = [];

function bindCallback(validationKey, matchVal, matchType) {
Expand Down
Expand Up @@ -634,7 +634,6 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, editorSt
formHelper.handleServerValidation(args.err.data.ModelState);

//add model state errors to notifications
// TODO: Need to ignore complex messages
if (args.showNotifications) {
showNotificationsForModelsState(args.err.data.ModelState);
}
Expand Down

0 comments on commit 99fc6ef

Please sign in to comment.