Include the PluginController Area when searching for matching surface… (

#12218)
umbraco · Apr 20, 2022 · f45d4a8 · f45d4a8
1 parent ce6a3d6
commit f45d4a8
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/src/Umbraco.Web.Website/Routing/ControllerActionSearcher.cs b/src/Umbraco.Web.Website/Routing/ControllerActionSearcher.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.AspNetCore.Http;
@@ -31,13 +32,20 @@ public class ControllerActionSearcher : IControllerActionSearcher
             _actionSelector = actionSelector;
         }
 
+
+        /// <summary>
+        /// Determines if a custom controller can hijack the current route
+        /// </summary>
+        /// <typeparam name="T">The controller type to find</typeparam>
+        public ControllerActionDescriptor Find<T>(HttpContext httpContext, string controller, string action) => Find<T>(httpContext, controller, action, null);
+
         /// <summary>
         /// Determines if a custom controller can hijack the current route
         /// </summary>
         /// <typeparam name="T">The controller type to find</typeparam>
-        public ControllerActionDescriptor Find<T>(HttpContext httpContext, string controller, string action)
+        public ControllerActionDescriptor Find<T>(HttpContext httpContext, string controller, string action, string area)
         {
-            IReadOnlyList<ControllerActionDescriptor> candidates = FindControllerCandidates<T>(httpContext, controller, action, DefaultActionName);
+            IReadOnlyList<ControllerActionDescriptor> candidates = FindControllerCandidates<T>(httpContext, controller, action, DefaultActionName, area);
 
             if (candidates.Count > 0)
             {
@@ -47,21 +55,29 @@ public ControllerActionDescriptor Find<T>(HttpContext httpContext, string contro
             return null;
         }
 
+
         /// <summary>
         /// Return a list of controller candidates that match the custom controller and action names
         /// </summary>
         private IReadOnlyList<ControllerActionDescriptor> FindControllerCandidates<T>(
             HttpContext httpContext,
             string customControllerName,
             string customActionName,
-            string defaultActionName)
+            string defaultActionName,
+            string area = null)
         {
             // Use aspnetcore's IActionSelector to do the finding since it uses an optimized cache lookup
             var routeValues = new RouteValueDictionary
             {
                 [ControllerToken] = customControllerName,
                 [ActionToken] = customActionName, // first try to find the custom action
             };
+
+            if (area != null)
+            {
+                routeValues[AreaToken] = area;
+            }
+
             var routeData = new RouteData(routeValues);
             var routeContext = new RouteContext(httpContext)
             {

diff --git a/src/Umbraco.Web.Website/Routing/IControllerActionSearcher.cs b/src/Umbraco.Web.Website/Routing/IControllerActionSearcher.cs
@@ -1,10 +1,16 @@
+using System;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc.Controllers;
 
 namespace Umbraco.Cms.Web.Website.Routing
 {
     public interface IControllerActionSearcher
     {
+
         ControllerActionDescriptor Find<T>(HttpContext httpContext, string controller, string action);
+
+        ControllerActionDescriptor Find<T>(HttpContext httpContext, string controller, string action, string area)
+                    => Find<T>(httpContext, controller, action);
+
     }
 }
diff --git a/src/Umbraco.Web.Website/Routing/UmbracoRouteValueTransformer.cs b/src/Umbraco.Web.Website/Routing/UmbracoRouteValueTransformer.cs
@@ -240,7 +240,7 @@ private RouteValueDictionary HandlePostedValues(PostedDataProxyInfo postedInfo,
                 [ActionToken] = postedInfo.ActionName
             };
 
-            ControllerActionDescriptor surfaceControllerDescriptor = _controllerActionSearcher.Find<SurfaceController>(httpContext, postedInfo.ControllerName, postedInfo.ActionName);
+            ControllerActionDescriptor surfaceControllerDescriptor = _controllerActionSearcher.Find<SurfaceController>(httpContext, postedInfo.ControllerName, postedInfo.ActionName, postedInfo.Area);
 
             if (surfaceControllerDescriptor == null)
             {