Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetCore: MenuRenderingNotification should send TreeAlias, so you can tell what tree you are on. #10054

Closed
KevinJump opened this issue Mar 24, 2021 · 1 comment

Comments

@KevinJump
Copy link
Contributor

The 'menuRenderingNotification' doesn't contain the tree alias, so when you subscribe to this notification event, you can't tell which tree you are on (e.g content, media, settings, etc.. so you can't write code to selectively add/remove items)

on v8 the 'TreeAlias' is part of the Sender object for Menu Rending events.,

this was added for Tree Node Rendering in pr PR #10024 - suspect very similar code is needed for MenuRendingNotifcations.

There are also other items on the Sender object missing in netcore (e.g SectionAlias, TreeGroup, TreeTitle).

However I am not sure how useful they are and if they need adding? (e.g it really shouldn't matter what section your tree is in if you know the TreeAlias)

@bergmania
Copy link
Member

Make sense.. I also added it to RootNodeRenderingNotification.

Thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants