Use umb-icon component for icons in content type groups and tabs

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

Description

It seems after the new tabs feature has been merged #10606 it doesn't consistent use <umb-icon> for icons as cleaned up in #10805

[umbrabot]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[ronaldbarendse]

@bjarnef Thanks for keeping an eye on this (and creating the PR) 👍🏻 @nul800sebastiaan I've already reviewed/tested it and we should make sure it's included in the 8.17 (if possible also in the RC).

[bjarnef]

@madsrasmussen in case you want to review this as well, it would be great to include in 8.17 final release 😉👍

[bjarnef]

@nul800sebastiaan this one would be great to include in v8.17 as well, so we specific use <umb-icon> for icons which makes it easier to ensure consistency throughout the backoffice UI.

[bjarnef]

We probably also want to merge this to v9 👍

[nathanwoulfe]

All looks good to me, thanks @bjarnef. Could this be the end of the umb-icon updates 😄

[nathanwoulfe]

Missed the boat for 8.17, but either 8.17.1 (if that release happens) or 8.18. Will be cherrypicked for v9 too (fyi @nul800sebastiaan)