Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11343: Remove blocklist block on cancel #11353

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

patrickdemooij9
Copy link
Contributor

@patrickdemooij9 patrickdemooij9 commented Oct 11, 2021

If there's an existing issue for this PR then this fixes #11343

It seems like the logic for this was already in place, but not fully connected yet. Now, I don't know if the way that I did this is the best way. Another idea was to pass the arguments through the edit function, but I don't know if that messes up anything for package developers that are using that function. Let me know if this solution is good enough or if another way is preferred!

BlockListCancel

@umbrabot
Copy link

umbrabot commented Oct 11, 2021

Hi there @patrickdemooij9, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@jannikanker
Copy link
Contributor

Should also fix #11218 .

Copy link
Contributor

@nathanwoulfe nathanwoulfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patrickdemooij9 I'm not really across the BlockList API, but this looks good to me - works as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocklist cancel not really cancelling Block list single item mode inserts empty block when cancelling
5 participants