Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with migration from 8 and added support for 8.18 migration #12020

Conversation

bergmania
Copy link
Member

@bergmania bergmania commented Feb 17, 2022

Fixes #11976

Fix issue with migration from 8 and added support for 8.18 migration.

The 8.18 have added a new noop migration (8ff1d49) just to change state, so we can but it into the right order in v9. Otherwise it would skip directly to 9.1 and continue from there.

The bug was fixed by reintoducting the old model from pre 9.3, and only use it for the old migrations

…s changed in 9.3, but added in 9.0. we need to use the legacy models when running 9.0 migrations
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and tested with:

  • 8.18 branch to this
  • 8.17.2 to this
  • 9.2 to this

And it all checks out 👍

@nikolajlauridsen nikolajlauridsen merged commit 3a269ed into v9/9.3 Feb 17, 2022
@nikolajlauridsen nikolajlauridsen deleted the v9/hotfix/fix_issue_with_migration_from_8_and_added_support_for_8.18_migration branch February 17, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants