Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to rollback content to the published version #12119

Closed
ronaldbarendse opened this issue Mar 9, 2022 · 9 comments
Closed

Unable to rollback content to the published version #12119

ronaldbarendse opened this issue Mar 9, 2022 · 9 comments

Comments

@ronaldbarendse
Copy link
Contributor

ronaldbarendse commented Mar 9, 2022

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

9.3.1

Bug summary

If you save changes on a published content node, you can't reset/rollback to the current published version again. The only way seems to be to publish the saved changes/current draft version, after which the previous published version can be selected in the rollback dialog, do the rollback and publish the content again.

Besides unnecessarily updating the content cache (and all other side-effects of a publish, like re-indexing in Examine, etc.) and potentially having incorrect content published for a brief moment, this also creates an additional content version that you can't manually clean up as well.

It's also not possible to compare the current draft and published versions, so you also can't see what changes are being published if there are any pending.

Specifics

No response

Steps to reproduce

  • Publish a content node
  • Make changes and only save
  • Try to rollback those changes or find out what actually changed

Expected result / actual result

If you only have a single published version and make some changes, the rollback dialog is basically useless, as you can't select the current draft or published version:
Only draft and published version

After publishing the changes, you can select the previously published version to rollback to:
Rollback to previous published version

But publishing that again creates an additional version:
Additional versions created

Also, the text above the comparison says This shows the differences between the current version and the selected version, but what current version is used to compare to, the draft or published one?

I would expect the following:

  • Do not show the current draft version in the list if it's the same as the published version (no pending changes)
  • If there is a draft version, allow comparing it to the published version and when rolling back, disregard any pending changes (so you end up in the state of the previous item)
  • Make it clear that you're comparing against the current draft version

In addition to this I found some other minor issues in the rollback dialog:

  • Selecting different versions doesn't update the title of the compare box (deselecting and selecting another version does however)
  • The Current version box only displays the node name and created date, not the updated date (and is useless anyway, as the node name is shown in the compare box and created date isn't really useful here - plus it doesn't account for culture variants that aren't created yet and have no name)
  • There's no way to remove/delete specific versions (would be nice to have a delete/trashcan and pin/unpin button, instead of the verbose prevent cleanup/enable cleanup)

This item has been added to our backlog AB#24054

@c9mb
Copy link

c9mb commented Jul 6, 2022

I was just checking out this behavior on V10 and it seems still to be the same.
There should be the ability to compare saved (but unpublished) changes to the current published version, and the ability to abandon saved changes, reverting back to the current published version.

@hfloyd
Copy link
Contributor

hfloyd commented Jul 8, 2022

I just came across this same behavior on a v8.13.2 site today.

@lbras
Copy link

lbras commented Sep 28, 2022

Same on 8.18.4. Completely agree, the rollback functionality is currently very confusing. The expected results proposed by @ronaldbarendse are the way to go!

@argentini
Copy link

This is clearly an omission. I'd venture to guess that most rollback scenarios would be rolling back to the previous published version. This needs to be fixed ASAP.

@argentini
Copy link

@nul800sebastiaan this affects version 10 as well. Can you take a look at this?

@PotatoDotJar
Copy link

I would think this should be an essential feature.

@lassefredslund lassefredslund added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Nov 10, 2022
@kjac kjac self-assigned this Nov 21, 2022
@kjac kjac mentioned this issue Nov 21, 2022
1 task
@kjac
Copy link
Contributor

kjac commented Nov 21, 2022

@ronaldbarendse really good stuff here ❤️

I've addressed (I think?) all your points in #13452 except this one:

  • There's no way to remove/delete specific versions (would be nice to have a delete/trashcan and pin/unpin button, instead of the verbose prevent cleanup/enable cleanup)

That's a somewhat larger task. I reckon we can do without for the time being at least - maybe we should add it to the backlog for future consideration?

Quick demo of the improvements:
rollback-improvements

@Zeegaan Zeegaan added release/10.4.0 release/11.1.0 and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Nov 23, 2022
@Zeegaan
Copy link
Member

Zeegaan commented Nov 23, 2022

Fixed in #12119 🚀

@Zeegaan Zeegaan closed this as completed Nov 23, 2022
@tenshi04
Copy link

I see this has been fixed in versions 10.4 and 11.1.0 but has this been fixed in the latest version of 8? Is there plan to?

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants