New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Content Tree Node Not Greyed Out #13253
Conversation
Hi there @vlaellayug, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi there @vlaellayug! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 18th, 2022, 09:00 AM UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
Thanks for this fix @vlaellayug, it makes the tree much clearer indeed 👍 |
Hi @nul800sebastiaan, @mikecp - is this gonna be released for older versions? |
Hi @vlaellayug , I have no idea, I leave it to @nul800sebastiaan to get this into previous versions if it fits 😁 |
Hello @mikecp, @nul800sebastiaan - thanks! I can help and make a PR for older versions, as this needs to be fixed for our V8+ sites too. |
Cherry picked for 10.4.0 a810c59 |
We are not going to be updating v8/9 with this, sorry, they're only getting security fixes now. |
Added an additional logic which adds the default culture when there's only 1 language configured.
Here's the following use cases made while debugging:
1.) The issue can be replicable if it only have one language and the "Document Type" is set to vary by culture.
2.) The issue cannot be replicable when there's 2 languages configured since the query string for the "culture" is appended before making the request to the API.
This fixes #12279