Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete old migrations and exif code #13382

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Obsolete old migrations and exif code #13382

merged 4 commits into from
Nov 14, 2022

Conversation

bergmania
Copy link
Member

@bergmania bergmania commented Nov 10, 2022 •
edited
Loading

You cannot migration dicrectly from v8 without going to v10 first anyway, so:

  • Obsolete public migrations from v8-v9.
  • Removed internal migrations from v8-v9.

We had a section of dead code related to EXIF data.

  • Obsoleted public methods.
  • Removed internal methods.

Reintroduced the package validation and targeted the first RC of 11.

  • Added suppressions for the deploy breaking changes.

Marked property editors as deprecated

  • Grid Layout
  • Nested Content

@bergmania bergmania mentioned this pull request Nov 11, 2022
Draft
1 task
nikolajlauridsen
nikolajlauridsen approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.8K removed lines, a sight of true beauty 😍

I've gone over the files and confirmed that the public stuff has been obsoleted, and the internal stuff has been removed 👍

@nikolajlauridsen nikolajlauridsen merged commit 616d092 into v11/dev Nov 14, 2022
@nikolajlauridsen nikolajlauridsen deleted the v11/feature/obsolete_stuff branch November 14, 2022 11:40
nikolajlauridsen pushed a commit that referenced this pull request Nov 14, 2022
@bergmania @nikolajlauridsen
Obsolete old migrations and exif code (#13382)
13308c3 
* Obsoleted and deleted internal migrations + Enabled breaking changes checks agains v11.0.0-rc1

* Obsoleted and deleted internal exif stuff

* Added CompatibilitySuppressions.xml

* Change GenerateCompatibilitySuppressionFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolajlauridsen nikolajlauridsen nikolajlauridsen approved these changes

Assignees
No one assigned
Labels
release/11.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergmania @nikolajlauridsen