IsBackOfficeRequest is extremely inefficient

[Nuklon]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v9, v10, v11

Bug summary

https://github.com/umbraco/Umbraco-CMS/blob/v11/contrib/src/Umbraco.Core/Routing/UmbracoRequestPaths.cs

This gets called a lot and does a lot of unnecessary things.

• It can optionally take the Path property from a Request instead of trimming the entire URL.
• _defaultUmbPaths is useless, this can just be a string.
• urlPath gets split by forward slash for PluginController, while this should just count slashes and avoid unnecessary allocations.

Created originally as a discussion here #11640 but this seems completely ignored.

Specifics

No response

Steps to reproduce

Just run Umbraco.

Expected result / actual result

Should be optimized.

[github-actions]

Hi there @Nuklon!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Zeegaan]

Hey @Nuklon, I agree it is inefficient, as you've already pointed out some good places to improve I will mark this as up for grabs, as we'd love some help with this 🙌

[github-actions]

Hi @Nuklon,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[Nuklon]

Hey @Nuklon, I agree it is inefficient, as you've already pointed out some good places to improve I will mark this as up for grabs, as we'd love some help with this 🙌

I had already created a PR for v9 but nothing happened with it. I can recreate for v11 if wanted...

[Zeegaan]

@Nuklon Yep we would love that 🙌

[Nuklon]

@Nuklon Yep we would love that 🙌

Great!
#13743