New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #13732 - IsBackOfficeRequest is extremely inefficient #13743
Conversation
Hi there @Nuklon, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @Nuklon ,
Thanks a lot for providing this performance improvement 👍
And also thanks for your patience since V9 for getting this in 😅
I have left two comments on which I would like to get your feedback. One of them aims at making this even more efficient 😉
Cheers!
@mikecp, is this OK to merge now? I'd rather not see this effort also go to waste 🙂 |
Hi @Nuklon, |
Hello @Nuklon , Here we go for the merge! Thank you for helping make Umbraco more performant 👍 I see that this is your first contribution, this is awesome! Congratulations!! 🎉 And we'll be looking forward to your next ones 😉 Cheers! |
* Update UmbracoRequestPaths.cs * Update UmbracoRequestPaths.cs * remove redundant check --------- Co-authored-by: Michael <michael@crossingpaths.be> (cherry picked from commit de27eb6) # Conflicts: # src/Umbraco.Core/Routing/UmbracoRequestPaths.cs
Cherry picked for 10.5 in 4f8b8b3 |
Prerequisites
If there's an existing issue for this PR then this fixes #13732
This greatly improves the performance of IsBackOfficeRequest.