Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13732 - IsBackOfficeRequest is extremely inefficient #13743

Merged
merged 4 commits into from Feb 16, 2023

Conversation

Nuklon
Copy link
Contributor

@Nuklon Nuklon commented Jan 26, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #13732

This greatly improves the performance of IsBackOfficeRequest.

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

Hi there @Nuklon, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan nul800sebastiaan changed the base branch from v11/contrib to contrib January 26, 2023 14:44
Copy link
Contributor

@mikecp mikecp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Nuklon ,
Thanks a lot for providing this performance improvement 👍
And also thanks for your patience since V9 for getting this in 😅

I have left two comments on which I would like to get your feedback. One of them aims at making this even more efficient 😉

Cheers!

src/Umbraco.Core/Routing/UmbracoRequestPaths.cs Outdated Show resolved Hide resolved
@nul800sebastiaan nul800sebastiaan changed the title Fixes #13732 Fixes #13732 - IsBackOfficeRequest is extremely inefficient Jan 31, 2023
@Nuklon
Copy link
Contributor Author

Nuklon commented Feb 11, 2023

@mikecp, is this OK to merge now? I'd rather not see this effort also go to waste 🙂

@mikecp
Copy link
Contributor

mikecp commented Feb 13, 2023

Hi @Nuklon,
Busy week last week, but don't worry, I'll check your PR in the coming days 👍

@mikecp
Copy link
Contributor

mikecp commented Feb 16, 2023

Hello @Nuklon ,

Here we go for the merge! Thank you for helping make Umbraco more performant 👍

I see that this is your first contribution, this is awesome! Congratulations!! 🎉
If you provide us with your account name on Our, @nul800sebastiaan will be very happy to assign our shiny contributor's badge to you 🥇

And we'll be looking forward to your next ones 😉

Cheers!

@mikecp mikecp merged commit de27eb6 into umbraco:contrib Feb 16, 2023
@mikecp mikecp added category/performance Fixes for performance (generally cpu or memory) fixes type/feature release/11.3.0 labels Feb 16, 2023
@Nuklon Nuklon deleted the patch-2 branch February 17, 2023 17:13
nul800sebastiaan pushed a commit that referenced this pull request Mar 21, 2023
* Update UmbracoRequestPaths.cs

* Update UmbracoRequestPaths.cs

* remove redundant check

---------

Co-authored-by: Michael <michael@crossingpaths.be>
(cherry picked from commit de27eb6)

# Conflicts:
#	src/Umbraco.Core/Routing/UmbracoRequestPaths.cs
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.5 in 4f8b8b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsBackOfficeRequest is extremely inefficient
4 participants