ContentPickerValueConverter should be public

[simonech]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

11.0

Bug summary

Why is ContentPickerValueConverter internal while all other value converters are public?

Specifics

https://github.com/umbraco/Umbraco-CMS/blob/v11/dev/src/Umbraco.Core/PropertyEditors/ValueConverters/ContentPickerValueConverter.cs

See others:
https://github.com/umbraco/Umbraco-CMS/blob/v11/dev/src/Umbraco.Core/PropertyEditors/ValueConverters/MultipleTextStringValueConverter.cs
https://github.com/umbraco/Umbraco-CMS/blob/v11/dev/src/Umbraco.Core/PropertyEditors/ValueConverters/MediaPickerValueConverter.cs

Steps to reproduce

Try writing an custom property editor that is just a content picker with some "preview" features, and try inheriting from that the core ContentPickerValueConverter.
You cannot.

Expected result / actual result

While you should be able to do so, like you can for all other Value Converters

[github-actions]

Hi there @simonech!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[simonech]

I mean, it's an easy fix that anyone can do as PR, but first would need to know if it was done on purpose or was just something forgotten by mistake

[Zeegaan]

@simonech Yep you are right, doesn't make sense to have it as the only internal one, seems like an error to me 👍
I will mark this as up for grabs and as a great first issue 👍

[Zeegaan]

Fixed in #13864 😁