Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed modifier for ContentPickerValueConverter #13864

Merged
merged 1 commit into from Feb 21, 2023

Conversation

simonech
Copy link
Contributor

@simonech simonech commented Feb 20, 2023

Changed access modifier of ContentPickerValueConverter from internal to public.
This Value Converter was the only one defined as internal while all others are public.
It was confirmed as bug
Fixes issue #13858

Changed internal to public for ContentPickerValueConverter, which was the only property value converter defined as `internal`
Fixes issue umbraco#13858
@github-actions
Copy link

github-actions bot commented Feb 20, 2023

Hi there @simonech, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan
Copy link
Member

Zeegaan commented Feb 21, 2023

Looks great, thanks for the quick PR 😁

@Zeegaan Zeegaan merged commit 362832b into umbraco:contrib Feb 21, 2023
nul800sebastiaan pushed a commit that referenced this pull request Mar 16, 2023
Changed internal to public for ContentPickerValueConverter, which was the only property value converter defined as `internal`
Fixes issue #13858

(cherry picked from commit 362832b)
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.5 in c684b38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants