Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect nullable return values throughout various classes #15926

Open
IvovdBruggen opened this issue Mar 21, 2024 · 1 comment · May be fixed by #15927
Open

Incorrect nullable return values throughout various classes #15926

IvovdBruggen opened this issue Mar 21, 2024 · 1 comment · May be fixed by #15927
Labels
type/bug

Comments

@IvovdBruggen
Copy link

IvovdBruggen commented Mar 21, 2024 •
edited

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.2.0

Bug summary

There are multiple methods that now return nullable types, that can safely be removed. I think this is a good QOL fix and prevents unnecessery null checks in codebases.

Solution

Check for info messages from the compiler that mention that the nullable return type can safely be changed to a non-nullable return type
@github-actions GitHub Actions
Copy link

Hi there @IvovdBruggen!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@IvovdBruggen IvovdBruggen linked a pull request Mar 21, 2024 that will close this issue
Open
@IvovdBruggen IvovdBruggen changed the title FriendlyPublishedContentExtensions: nullable return value for method that cannot return null Incorrect nullable return values throughout various classes Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix nullability of return types that can be non-null IvovdBruggen/Umbraco-CMS
1 participant
@IvovdBruggen