Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullability of return types that can be non-null #15927

Open
wants to merge 2 commits into
base: contrib
Choose a base branch
from

Conversation

IvovdBruggen
Copy link

@IvovdBruggen IvovdBruggen commented Mar 21, 2024

This fixes #15926

Changes

Fixes nullability of methods exposed in various Umbraco extensions.

Copy link

Hi there @IvovdBruggen, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@IvovdBruggen
Copy link
Author

Realising now that this is a very small pull request, does it sound good that I also fix all the other nullability return warnings? Excluding obsolete methods that is.

@georgebid
Copy link
Contributor

Hey @IvovdBruggen! Thank you for your PR to fix #15926, someone on the team will review this soon 😄 and in terms of creating a new issue, it's up to you really, you could either create a new one or add on to 15926, and then you could update your PR too 😄 And I agree, probably best to leave anything that is obsolete.

@IvovdBruggen IvovdBruggen changed the title Fix nullability of Children extension in FriendlyPublishedContentExtensions Fix nullability of return types that can be non-null Mar 22, 2024
@IvovdBruggen
Copy link
Author

@georgebid Great! I have updated the issue and PR and will commit the other fixes!

@georgebid georgebid self-assigned this Mar 25, 2024
@IvovdBruggen
Copy link
Author

Any progress on this perhaps? Came by the same issue today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect nullable return values throughout various classes
2 participants