Updates .NET Framework to 4.5.2 and updates dependencies #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
# Conflicts: # build/NuSpecs/UmbracoCms.Core.nuspec # src/Umbraco.Tests/packages.config # src/Umbraco.Web.UI/packages.config # src/Umbraco.Web/packages.config # src/umbraco.MacroEngines/packages.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Net 4.5.0 and 4.5.1 have been out of support by Microsoft for several years.
Some dependencies that Umbraco uses are no longer shipped with support for .Net 4.5.0 which means that Umbraco needs to update it's minimum target framework to the supported .Net 4.5.2 in order to be able to use the newer available dependencies.
All web services will be running the latest .Net framework version and in most cases this will be .Net 4.7.x since the .Net framework is updated by Microsoft update services. This actually means that most Umbraco websites are being hosted by much more recent frameworks and they work without issue. This is because there are special
targetFrameworkproperties in theweb.configwhich force a given website to run under the same feature-set as the one specified even though the host framework is a later version. What this all means is that there will be no issues with changing the minimum framework to .Net 4.5.2. This PR also sets the targetFramework in the web.config to 4.5.2 since there is no issue running Umbraco under that feature-set.The issue that arises from this change is that other Visual Studio projects that are built against Umbraco nuget packages will need to bump their target framework to at least 4.5.2 if it's currently set to 4.5.0 or 4.5.1.
This PR updates the Nuspec to show the dependency on .Net 4.5.2, it also adds framework dependencies so that when installing via nuspec, those framework assemblies are automatically added to the project. This is a convenience thing since in many cases you need to manually add the System.Configuration reference.
This PR updates to the latest versions of MVC, WebApi and Owin - there should be no breaking changes there (some of this was not possible until we moved to 4.5.2). Other library updates include: Image Processor libs (this was not possible until we moved to 4.5.2), HtmlAgilityPack, latest compatible CodeAnalysis & DotNetCompilerPlatform libs, latest other MS libs like ValueTuple, Dataflow, Reflection.Metadata. All of these updates are non-major version updates.
One update is the Newtonsoft.Json dependency which is a major version update but we've not had issues with this in the past. There are a substantial amount of fixes from the 10.x -> 11 versions and very few breaks that i think would affect us.