Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dialogService #3637

Closed
madsrasmussen opened this issue Nov 15, 2018 · 5 comments
Closed

Remove dialogService #3637

madsrasmussen opened this issue Nov 15, 2018 · 5 comments
Labels
category/breaking release/8.0.0
Milestone
sprint98

Comments

@madsrasmussen
Copy link
Contributor

dialogService has been deprecated since 7.4 and it is now time to get it removed.
@madsrasmussen madsrasmussen self-assigned this Nov 15, 2018
@dawoe
Copy link
Contributor

dawoe commented Nov 15, 2018

So does this mean all calls need to be replaced with umb-overlay ?

@madsrasmussen
Copy link
Contributor Author

madsrasmussen commented Nov 15, 2018 •
edited by warrenbuckley
Loading

PR: #3625

The PR removes the dialogService and refactors the last bit and pieces that used it.

  • Login screen (login, invite, reset password)
  • Context menu + dialogs

This PR is made in the process of removing dependencies from bootstrap. The PR adds a new component for the login screen which is added on top of the rest of the UI when login is required (the same approach to how the dialogService handled it). It also adds a new component for the context-menu dialog. I have done some code clean up which was related to the dialogService and legacy views. I have also removed a couple of global events which bound click events and "esc" keypress in the main.controller and added them to the right components instead so we can unbind when the dialogs are not open.

Missing:
2 factor authentication hasn't been refactored and needs to be fixed. I have added a task to fix up the code: #3624

How to test:
Login screen

  • make sure you can log in to Umbraco
  • make sure you can log out of Umbraco
  • make sure validation messages are shown if you enter wrong username/password

Reset Password

  • make sure you can reset your password

Invite user

  • make sure you can invite a new user
  • make sure you can upload an avatar for the new user

Context Menu

  • make sure you can open the context menu (click the three dots next to a tree item)
  • make sure you can close the context menu by clicking outside of it or by using "Esc."
  • make sure you can open a context menu item
  • make sure you can close a context menu item by clicking outside of it or by using "Esc."

@madsrasmussen madsrasmussen removed their assignment Nov 15, 2018
@madsrasmussen
Copy link
Contributor Author

@dawoe Yes, or the editorService (added in v8 for infinite editing). More documentation will follow.

@dawoe
Copy link
Contributor

dawoe commented Nov 15, 2018

Yep..this one will need docs.. Will be a breaking change for all packages still using dialogService. Especially steps on how to migrate

Dave

@clausjensen clausjensen added this to the sprint98 milestone Nov 15, 2018
@warrenbuckley
Copy link
Contributor

All good & merged

@ghost ghost removed the state/review label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/breaking release/8.0.0
Projects
None yet
Milestone
sprint98
Development

No branches or pull requests
4 participants
@dawoe @warrenbuckley @clausjensen @madsrasmussen