Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations #3653

Closed
madsrasmussen opened this issue Jul 5, 2018 · 3 comments
Closed

Animations #3653

madsrasmussen opened this issue Jul 5, 2018 · 3 comments

Comments

@madsrasmussen
Copy link
Contributor

child of #3649

We need another round of animation fixes. We never found a solution to the bad performing animations. With the upgraded Angular we now have access to more ngAnimate classes and we might be able to do a full CSS-animated solution now instead of relaying on javascript animations and a 3rd-part library.

@madsrasmussen
Copy link
Contributor Author

PR: #3897

The PR reenables the infinite editing animations.

How to test:

  • Open an infinite editing workflow (Ex. add a property to a doctype)
  • Make sure the infinite editing panels slide in and out

@Shazwazza
Copy link
Contributor

@madsrasmussen so do animations now perform well? I can confirm it all works, just don't know if this now performs better based on what code has changed since there's not really optimizations in the code.

@Shazwazza
Copy link
Contributor

I've merged it in but just want to know how it performs better or if we are just going to accept the performance (for me it's seemed ok)

@Shazwazza Shazwazza self-assigned this Dec 19, 2018
@ghost ghost removed the state/review label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants