Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jquery to latest #3793

Closed
madsrasmussen opened this issue Nov 28, 2018 · 6 comments
Closed

Upgrade jquery to latest #3793

madsrasmussen opened this issue Nov 28, 2018 · 6 comments

Comments

@madsrasmussen
Copy link
Contributor

No description provided.

@madsrasmussen
Copy link
Contributor Author

PR: #3792

I have upgraded jquery to latest version. My approach was to install jquery migrate and check for any broken stuff. Everything seemed to still work fine after the upgrade but we got a bunch of depricated api's that they recommended moving away from. I have updated the code so we no longer use these in our own code. We still have plugins using these but it is not a problem before jQuery 4.

*How to test:
I don't think a whole lot of testing is needed for this one. We will catch if any bugs should have slipped through the cracks when moving forward. Jquery-migrate didn't find anything so I think we should be fine.

  • Sanity check code for updates.
  • Make sure the back office still runs. Do a couple of tests you think is needed based on the code changes. It could be:
    -- Add a couple of doc types
    -- Edit a bit of content
    -- Upload some images
    -- Edit a template

@dawoe
Copy link
Contributor

dawoe commented Nov 29, 2018

Hi @madsrasmussen

Where is jQuery being used in the backoffice ?. And the question is do we still need it ? Most things can be done with plain javascript nowadays.

Dave

@madsrasmussen
Copy link
Contributor Author

We still use it quite a lot and we still use a couple of libraries that are dependant on jQuery. We are working towards getting it removed but it won't be today 😃Now it is the latest version at least.

@dawoe
Copy link
Contributor

dawoe commented Nov 29, 2018

Would be nice to have some clean up done.

Will keep an eye out if I work on something that uses jQuery and can be replaced by vanilla js I will update it

@madsrasmussen
Copy link
Contributor Author

Great! That is the way to go. I am also swapping out libraries when I get the chance to something that isn't dependant on jQuery. One day, we will be able to ship without it :)

The first step could be to have a look at jQuery UI. I think that would be a good start to remove that one.

@warrenbuckley
Copy link
Contributor

Tested & all happy. If we run into any problems then we will fix them along the way

@ghost ghost removed the state/review label Dec 3, 2018
@Shazwazza Shazwazza added this to the sprint99 milestone Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants