Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration based index/searchers and index sets #3901

Closed
Shazwazza opened this issue Dec 18, 2018 · 5 comments
Closed

Remove configuration based index/searchers and index sets #3901

Shazwazza opened this issue Dec 18, 2018 · 5 comments

Comments

@Shazwazza
Copy link
Contributor

child of #3530
requires #3535

Examine no longer ships with configuration based indexes and searchers since configuration is not flexible, it's archaic/legacy and it's actually less simple than code.

Umbraco already creates and configures the indexes it ships with via code, however Umbraco still has it's own configuration based index features like IndexSet (which was moved from Examine to Umbraco since Examine no longer supports config).

So all configuration based index code needs to be removed

@Shazwazza
Copy link
Contributor Author

PR #3902

Be sure to review #3535 first!

@Shazwazza Shazwazza removed their assignment Dec 18, 2018
@zpqrtbnk zpqrtbnk self-assigned this Dec 18, 2018
@zpqrtbnk
Copy link
Contributor

Have merged latest temp8. Cannot merge the PR for now: tests failing in PublishMediaCacheTests and PublishMediaTests because "No index found by name InternalIndex" - assuming that's because the tests don't configure the indexes anymore? How should they do it?

@clausjensen clausjensen modified the milestones: sprint100, sprint102 Jan 6, 2019
@Shazwazza
Copy link
Contributor Author

@zpqrtbnk tests are fixed, was a simple change, see e20e570

@Shazwazza
Copy link
Contributor Author

@zpqrtbnk have also pushed fixes for the issue of rebuilding indexes seeming to timeout.

@zpqrtbnk
Copy link
Contributor

tests green, site runs, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants