Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust disabled toggle #3962

Closed
bjarnef opened this issue Jan 6, 2019 · 4 comments
Closed

Adjust disabled toggle #3962

bjarnef opened this issue Jan 6, 2019 · 4 comments

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Jan 6, 2019

In languages view in v8 the default language toggle looks disabled because of the following css:

.umb-permission--disabled {
    opacity: .8;
}

image

I think the umb-toggle (button element) should have a disabled state, where browsers doesn't focus on disabled elements (as with a diabled checkbox) when using keyboard tab key and it doesn't have the box shadow in disabled state as in active and focus state.

Browsers also have a default cursor style on disabled elements, but we can also control this using something like this:

.umb-toggle:disabled, .umb-toggle:disabled .umb-toggle__toggle {
    cursor: not-allowed;
}

Furthermore it seems the checkmark or cross icons needs to adjusted so they are centered vertically.

@nul800sebastiaan
Copy link
Member

Thanks for the PR, we'll have a look soon! 👍

@bjarnef
Copy link
Contributor Author

bjarnef commented Jan 7, 2019

@nul800sebastiaan I think the PR can be cherry picked to dev-v7 except commit 0d8450e

@nul800sebastiaan
Copy link
Member

Fixed in #3967

@nul800sebastiaan
Copy link
Member

Cherry picked for v7: d53d0b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants