incorrect permissions required for Notifications sign up

[matthew-hair]

To list and sign up for notifications on a node, a user must have the "Permissions" permission, which "Allow access to change permissions for a node". By default, this excludes members of the Writers and Editors groups. These groups should normally be able to receive notifications.

Reproduction

In Umbraco 7.12.0 and higher:

1. Log in to the back office as a user who doesn't have "Permissions" permission (for example, a member of the Editors group).
2. Navigate to the Content section, right-click a node, and click Notifications.

Expected result

I would expect to see a list of toggles that allow the user to choose which node changes that will trigger a notification email to be sent to the user.

Actual result

Umbraco displays a permissions error in place of the list of toggles:

Location of the bug in the code

The bug is caused by a typo in the GetNotificationOptions(int contentId) method in the Umbraco.Web.Editors.ContentController class:
[EnsureUserPermissionForContent("contentId", 'R')] public IEnumerable<NotifySetting> GetNotificationOptions(int contentId) { … }

Instead of checking for the 'R' permission, it should check for the 'F' permission, which is the code for "Browse Node", "Allow access to view a node".

[nul800sebastiaan]

Thanks, fixed for 7.14!

[matthew-hair]

Awesome, thanks!