Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8: Component / Composers mixing namespaces #4566

Closed
mattbrailsford opened this issue Feb 13, 2019 · 5 comments
Closed

V8: Component / Composers mixing namespaces #4566

mattbrailsford opened this issue Feb 13, 2019 · 5 comments
Assignees
@warrenbuckley
Labels
release/8.0.0 type/bug
Milestone
sprint104

Comments

@mattbrailsford
Copy link
Contributor

In the V8 source there are namespaces for Composing and Components however there appears to be crossover in the classes in these namespaces. ie, the 'IComposerandIUserComposerinterfaces are in theComponents` namespace. I think these need going through and making sure they are in the correct namespaces.
@zpqrtbnk zpqrtbnk self-assigned this Feb 13, 2019
@zpqrtbnk
Copy link
Contributor

Yes - will clean up.

@clausjensen clausjensen added this to the sprint104 milestone Feb 14, 2019
@zpqrtbnk zpqrtbnk mentioned this issue Feb 14, 2019
Merged
@zpqrtbnk
Copy link
Contributor

PR #4573 - what do you think @mattbrailsford ?

@mattbrailsford
Copy link
Contributor Author

Replied in PR #453 but overall, much better.

@mattbrailsford
Copy link
Contributor Author

mattbrailsford commented Feb 14, 2019 •
edited
Loading

Just gonna reference #4376 as it is kind of a linked issue (more mixed namespaces)

@zpqrtbnk
Copy link
Contributor

the PR for this issue has been merged - closing

@ghost ghost removed the state/review label Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warrenbuckley warrenbuckley

Labels
release/8.0.0 type/bug
Projects
None yet
Milestone
sprint104
Development

No branches or pull requests
5 participants
@mattbrailsford @warrenbuckley @clausjensen @zpqrtbnk @umbrabot