Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: Richtext editor view source code editor should get focus #5363

Closed
christophnz opened this issue Apr 30, 2019 · 3 comments · Fixed by #5398
Closed

v8: Richtext editor view source code editor should get focus #5363

christophnz opened this issue Apr 30, 2019 · 3 comments · Fixed by #5398

Comments

@christophnz
Copy link
Contributor

christophnz commented Apr 30, 2019

Bug summary

After clicking the View Source Code icon in the Richtext editor, the code editor opens, but doesn't get focus, so if I start typing or paste, the content still goes into whatever field last had focus.

Specifics

Umbraco v8.0.1
Reproduced in Firefox 66 and Chrome 73

Steps to reproduce

  • Put the focus (cursor) in any text field or the richtext editor
  • Click the View Source Code button
  • Type or paste some content
  • Click Close
  • The typed/pasted content is in the text field or richtext editor that last had focus

Expected result

The code editor should get the focus to avoid accidentally editing content that is hidden behind the code editor

Actual result

I accidentally pasted HTML code into a text field that was hidden behind the code editor and still had focus.

@nul800sebastiaan
Copy link
Member

Yeah, that seems annoying 🙈

I've marked this as "Up for grabs" so that you or someone else coming along could create a pull request for it.

Relates to #5220 as well.

@kjac
Copy link
Contributor

kjac commented May 3, 2019

That indeed is annoying! Nice catch!

PR in #5398

@nul800sebastiaan
Copy link
Member

Fixed in #5398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants