Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Support auto focus on ACE editor and use it for RTE source view #5398

Merged
merged 2 commits into from May 21, 2019

Conversation

kjac
Copy link
Contributor

@kjac kjac commented May 3, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #5363

Description

See excellent steps to reproduce in #5363.

This PR introduces an option to auto focus the ACE editor, and said option is then used for the RTE source view. When applied it works like this:

rte-code-view-focus

@emmaburstow
Copy link
Contributor

Hey @kjac

Excellent giffing! Thanks for the work. Speak soon,

Emma

@christophnz
Copy link
Contributor

Nice, thanks for fixing! Hope this makes it into the next release soon.

@nul800sebastiaan
Copy link
Member

Thanks @kjac ! I haven't looked at this yet, but how hard would it be to get rid of the horizontal scroll bar as well here?
There's a separate issue for that here: #5220

But I'd be happy if that can be fixed in this PR too, no need for a separate one.

@kjac
Copy link
Contributor Author

kjac commented May 6, 2019

@nul800sebastiaan I did dig into it, but it's not so easily fixed. The horizontal scroll bar shows up because of some inline styling and explicit widths applied by the ACE editor; maybe due to some outer element absolute positioning, maybe due to something else I can't see at the moment. In any case I believe the scrollbar issue should be solved on its own.

@nul800sebastiaan
Copy link
Member

Okidoki, thanks!

@kjac
Copy link
Contributor Author

kjac commented May 6, 2019

...well I'll be damned. Seems there's an ACE option that can be set after all!

I'll update this PR 👍

@kjac
Copy link
Contributor Author

kjac commented May 6, 2019

...and now the lines wrap nicely:

image

@nul800sebastiaan
Copy link
Member

This is great, thanks very much! 👍

@nul800sebastiaan nul800sebastiaan merged commit b270db7 into umbraco:v8/dev May 21, 2019
@kjac kjac deleted the v8-fix-rte-codeview-autofocus branch May 21, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v8: Richtext editor view source code editor should get focus
4 participants