V8 Remove duplicate comments in MediaService #5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevetemple
changed the title
|
Hiiiii Steeeeeeeeve! Thanks for the work. Nice tidy up here. When the tests are done I'll take a look and approve if all is well. Em |
emmaburstow
approved these changes
Jun 19, 2019
|
All good, cheers @stevetemple ! 👍 |
nul800sebastiaan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started looking at reimplementing #3568 in V8 and realised there were a load of comments in MediaService that are duplicated. Possibly some tooling issue?!
I have removed the duplicated comments in this PR as a base before working on hiding files in the recycle bin