Health Check - Text alternatives for icons missing #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: webdokkeren <thormadsenholm@gmail.com>
|
Woohoo! Thanks for the PR, well done gentlemen and congrats on entering Hacktoberfest a liiiiittle early this year! 🎉 Oh, and I hear it's @webdokkeren's very first Umbraco PR! So you now have that shiny new contributor badge on Our Umbraco, congrats! 🥇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @webdokkeren thormadsenholm@gmail.com
Prerequisites
This fixes issue no. 152 from #5277
Description
In this PR we have added a few next texts for "passed", "warning", "failed" and "suggestion" in the language files.
In the health check view these texts have been added inside a
<span class="sr-only">, which means a screen reader will announce for instance "Configuration 1 passed, 2 warning" depending on what's exposed to the DOM.We realise that pluralized texts need to be handled but that is something that needs to be done in another task as it's something that's not available out of the box currently and will affect other scenarios as well. This is a lot better than having no texts at all 😃