Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the leftover code from the legacy MacoContainer datatype #6467

Closed
nul800sebastiaan opened this issue Sep 29, 2019 · 3 comments · Fixed by #6518
Closed

Remove the leftover code from the legacy MacoContainer datatype #6467

nul800sebastiaan opened this issue Sep 29, 2019 · 3 comments · Fixed by #6518
Labels
community/pr release/8.4.0 type/feature

Comments

@nul800sebastiaan
Copy link
Member

As discovered through PR #6350 - we didn't intend to ship with code for the MacroContainer datatype.

The old code supporting this datatype needs to be removed, it quite broken at the moment anyway.

We'd love some help with this.
@Kerl1310
Copy link

Kerl1310 commented Oct 9, 2019

I'm happy to pick this up

Kerl1310 added a commit to Kerl1310/Umbraco-CMS that referenced this issue Oct 10, 2019
@Kerl1310
Fixes umbraco#6467 - Removing code references to MacroContainer
6ed9790
@Kerl1310 Kerl1310 mentioned this issue Oct 10, 2019
Closed
1 task
@Kerl1310
Copy link

@nul800sebastiaan Opened a PR for this

@nul800sebastiaan
Copy link
Member Author

Fixed in #6518

@pirvandrei pirvandrei mentioned this issue Oct 16, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community/pr release/8.4.0 type/feature
Projects
None yet
Milestone
No milestone
4 participants
@nul800sebastiaan @clausjensen @Kerl1310 @umbrabot