Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibilty improvement to media picker #6805

Merged
merged 3 commits into from
Nov 1, 2019

Conversation

MMasey
Copy link
Contributor

@MMasey MMasey commented Oct 21, 2019

Description

This PR fixes an accessibility issue where it wasn't possible to navigate to the media picker when navigating with a keyboard.

Demo GIF

media-picker-accessibility-improvements

@poornimanayar
Copy link
Contributor

Hi again @MMasey ,

Another great fix! We shall test and get back to you :-)

Poornima

Copy link
Contributor

@emmaburstow emmaburstow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is allllll good

Copy link
Member

@nul800sebastiaan nul800sebastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MMasey - for some more accessibility fixes, you could update the <i> icon elements to have aria-hidden="true" right?

@MMasey
Copy link
Contributor Author

MMasey commented Nov 1, 2019

Morning @nul800sebastiaan, i've made those changes for you 🙂

@nul800sebastiaan nul800sebastiaan merged commit 88af496 into umbraco:v8/dev Nov 1, 2019
@nul800sebastiaan
Copy link
Member

Lovely, feels great to use! 👍 Thank you!!

@nul800sebastiaan
Copy link
Member

Hi there @MMasey,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

We have had another record breaking amount of PR's in both the CMS, Documentation, and other smaller public repositories. You can read all about the numbers in the Umbraco Hacktoberfest round-up blog post.

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before December 19th 2019.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before February, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants