Log viewer: Filter toggle #6863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Umbraco.Web.UI.Client/src/views/logviewer/search.html
|
Thanks! FYI This one got a lot trickier to merge @BatJan due to the search.html now having translations and this PR not having those yet, so I had to be careful. Think I managed though 🤞 |
|
@nul800sebastiaan Ah, sorry about that - Tried doing the thing where I did more minor PR's to make the review process easier... turns out it made the merging experience worse... 🤷♂ 😁 I'm confident you managed to get it right though 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I have improved the filter dropdown, converting the
<a>to<button>and adding appropiate aria attributes as well.I have also added some empty
altattributes on the images rendering the favicons for different searches. This is done in order to let screen readers know they can safely ignore the image since the provided text is adequate in a non-visual context.Furthermore I have modified some styling so the control aligns with the left edge and looks better in general.
There is more stuff to be done in this view but I'm going to split it all up in smaller PR's since doing one big file, would be confusing for everyone involved 😃
Before
After
