User Details View Accessibility Improvement #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poornimanayar this makes so much sense! Could I ask you to resolve the merge conflicts on this one, so we can review it? Please note that I have changed the base branch from |
# Conflicts: # src/Umbraco.Web.UI.Client/src/views/components/umb-mini-list-view.html
kjac
requested changes
Dec 27, 2019
There was a problem hiding this comment.
Hi @poornimanayar ... thank you for merging things up.
It looks like you have accidentally broken the changes made in #7107 - the "change photo" button now shows again for users without a photo:
Could you please have another look at this?
|
I have added that back, i was clearly having a bad merge day yday |
kjac
approved these changes
Jan 2, 2020
|
...and merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the user details screen, the "Change Photo" and "Remove Photo" are currently
<a>. Changed them to be link style buttons.