Icon picker: Accessibility improvements #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BatJan , Thanks yet again! Poornima |
kjac
requested changes
Dec 21, 2019
There was a problem hiding this comment.
@BatJan this works just fine 👍
If I'm not mistaken there's really no reason to leave behind the .umb-iconpicker-item a rules in the LESS file, is there? I can't find anywhere else in the codebase using .umb-iconpicker-item, and with these changes there's no longer any a tag in there.
But maybe you had a good reason to keep those rules in place?
kjac
approved these changes
Jan 13, 2020
|
I went ahead and deleted those obsolete styles to get this merged in. |
|
...aaaand merged 👍 thanks again, @BatJan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
In this PR I have done the following
<a>to<button><buttonis usedaria-hidden="true"Visually everything looks the same as before 😃