Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logviewer log level colors #8513

Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 29, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This PR updates a few things in log viewer:

  • Replace anchors with <button> elements
  • Use <umb-icon> and fixes issue with toggle arrow up/down icon when open/close "saved searches"
  • Fixes issue with self-closing angular <umb-checkbox> component in log levels dropdown (in this case the self-closing custom angular element didn't cause issues except additional whitespace)
  • Updates log levels colors to better match the log level type
  • Empty state message isn't showm while loading (e.g. when selecting the different log levels from the dropdown)

I think the colors of the log levels was a bit off. Often "orange" is associated with "warning" and "red" is associated with "error".
I have then chosen a dark gray (close to black for "Fatal" log level). Furthermore I have updated "Debug" to use a blue "info" color, since "Debug" and "Verbose" colors is a bit too close to each other.

I searched a bit for "log level colors" and something like these examples seemed to be familiar:

image

image

@bjarnef
Copy link
Contributor Author

bjarnef commented Jul 29, 2020

Before

chrome_2020-07-29_19-43-26

After

image

@nathanwoulfe
Copy link
Contributor

For what it's worth, I like it. 🎨

@nul800sebastiaan nul800sebastiaan merged commit d1d50f2 into umbraco:v8/contrib Jul 30, 2020
@nul800sebastiaan
Copy link
Member

Looks great to me too! I added rel="noreferrer" to links that have target="_blank" for security reasons.

@nul800sebastiaan nul800sebastiaan changed the title Logviewer adjustments Update logviewer log level colors Jul 30, 2020
@bjarnef
Copy link
Contributor Author

bjarnef commented Jul 30, 2020

Thanks @nul800sebastiaan
I will try to remember adding this in future for other links with target="_blank"
https://web.dev/external-anchors-use-rel-noopener/

@bjarnef bjarnef deleted the v8/feature/logviewer-adjustments branch August 2, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants