-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logviewer log level colors #8513
Merged
nul800sebastiaan
merged 12 commits into
umbraco:v8/contrib
from
bjarnef:v8/feature/logviewer-adjustments
Jul 30, 2020
Merged
Update logviewer log level colors #8513
nul800sebastiaan
merged 12 commits into
umbraco:v8/contrib
from
bjarnef:v8/feature/logviewer-adjustments
Jul 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…den on wrapper element
For what it's worth, I like it. 🎨 |
Looks great to me too! I added |
nul800sebastiaan
added
category/ui
User interface
community/pr
release/8.8.0
type/feature
labels
Jul 30, 2020
nul800sebastiaan
changed the title
Logviewer adjustments
Update logviewer log level colors
Jul 30, 2020
Thanks @nul800sebastiaan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR updates a few things in log viewer:
<button>
elements<umb-icon>
and fixes issue with toggle arrow up/down icon when open/close "saved searches"<umb-checkbox>
component in log levels dropdown (in this case the self-closing custom angular element didn't cause issues except additional whitespace)I think the colors of the log levels was a bit off. Often "orange" is associated with "warning" and "red" is associated with "error".
I have then chosen a dark gray (close to black for "Fatal" log level). Furthermore I have updated "Debug" to use a blue "info" color, since "Debug" and "Verbose" colors is a bit too close to each other.
I searched a bit for "log level colors" and something like these examples seemed to be familiar: