-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Eye Dropper Color Picker as a datatype #9646
Add Eye Dropper Color Picker as a datatype #9646
Conversation
Not sure if a better name than "Eyedropper" might fit this color picker. Maybe "Compact Color Picker" or "Tiny Color Picker"? |
"Color Palette Picker", "Palette Color Picker", "Spectrum Color Picker",..? |
I have changed the alias of the picker to I also considered the name "Spectrum Color Picker" with alias |
@nielslyngsoe maybe you have some feedback on this PR? 🙂 |
We're loving it! Thanks for the work @bjarnef - looking really good and works well! 👍 |
Any plans on making the Palette configurable? |
@bjarnef |
@nielslyngsoe I believe the red messages is just the core UI ... I recall these where later changes to a yellow/warning style instead. I think what @vaskinhu is asking for regarding making the Palette configurable, is that the default palette in the color picker does have this option to add specific colors (instead of the default ones), e.g. red, green, blue, yellow, orange and purple, but not sure we want that in core to keep it simple. However it is always possible to create a custom property editor with more configuration options. |
Prerequisites
Description
Now that we have
<umb-color-picker>
component since Umbraco v8.10.0 #8812 and we also use this for configuration of background and icon color in Block List editor #9056 it would be nice to have a basic color picker property editor.We already have the "Approved Color" datatype instance using "Color Picker" property editor, which work great most of the time. However for various projects we have had the need using a wider range of colors, where the current color property editor might not always fit the needs.
This PR implement a Eyedropper Color Picker (naming is hard, so we might want to rename this - however "Color Picker" and "colorpicker" alias is already reserved by the current property editor).
Configuration
Limited to just the most basic configuration.
Content