Fixes #9824 - Filtering in block picker doesn't work #9831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #9824
Description
Currently the block picker is showing filter, when enough blocks are available. However the filtering didn't work.
Furthermore when opening the block picker it was scrolling down to last block, because the auto focus set here was stealing focus from the filter. Event worse when start typing in the search input you suddently lost focus, probably because the filtered results now changes the indexes and the
umb-auto-focus
watched these block cards. For now I have removing the, but we can always add it again, when we fix this. For now it works better without the auto focus on the block cards. f6a3168I have furthermore cleaner up using
<umb-editor-container>
instead of all the hardcoded classes and also replaced the search filter with<umb-search-filter>
component.Finally I have fixed the filtering, so it now works correctly.
However I noticed it didn't seems to filter the image block correctly. I named the alias of this
blockImage
since a document type with aliasimage
was already in use.Strange enough it does filter the blocks in searching
block
or a rename the aliaspicture
and search onpicture
.