New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dashboards support deep linking #10283
Conversation
Hi there @madsrasmussen, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
@madsrasmussen I tried changing the base branch to v8/contrib so I can merge, but that picked up an additional commit (so I flipped back to v8/dev). Reckon you could change the base and address the additional commit? This is a great addition, it's something I've tried to hack around in packages so will be brilliant to have in core. |
src/Umbraco.Web.UI.Client/src/views/common/dashboard.controller.js
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/views/common/dashboard.controller.js
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/views/common/dashboard.controller.js
Outdated
Show resolved
Hide resolved
Cool, tested and it works well. Even if you are not logged in you are still getting to the right dashboard when logging in. |
This PR makes dashboards support deep linking. It adds the alias as a query param when switching between dashboards and loads the correct dashboard on page load.
How to test: