Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dashboards support deep linking #10283

Merged
merged 5 commits into from Jun 17, 2021

Conversation

madsrasmussen
Copy link
Contributor

This PR makes dashboards support deep linking. It adds the alias as a query param when switching between dashboards and loads the correct dashboard on page load.

Screenshot 2021-05-18 at 14 25 25

How to test:

  • Make sure you can change dashboards in each section.
  • Make sure the query params get updated with the dashboard alias
  • Make sure you can link directly to a dashboard
  • Make sure the first dashboard is active if you don't have a dashboard query param or type in a random alias

@umbrabot
Copy link

umbrabot commented May 19, 2021

Hi there @madsrasmussen, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nathanwoulfe nathanwoulfe changed the base branch from v8/dev to v8/contrib May 19, 2021 22:53
@nathanwoulfe nathanwoulfe changed the base branch from v8/contrib to v8/dev May 19, 2021 22:53
@nathanwoulfe
Copy link
Contributor

@madsrasmussen I tried changing the base branch to v8/contrib so I can merge, but that picked up an additional commit (so I flipped back to v8/dev). Reckon you could change the base and address the additional commit?

This is a great addition, it's something I've tried to hack around in packages so will be brilliant to have in core.

@nielslyngsoe
Copy link
Member

Cool, tested and it works well. Even if you are not logged in you are still getting to the right dashboard when logging in.

@nielslyngsoe nielslyngsoe merged commit 585f7bb into v8/dev Jun 17, 2021
@nielslyngsoe nielslyngsoe deleted the v8/feature/deeplinkable-dashboard branch June 17, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants