U4-7891 Image Cropper needs a property value converter to return a strongly typed model, json or a string when requested. #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ namespace Umbraco.Core.PropertyEditors | |||
| /// <summary> | |||
| /// Manages the list of IPropertyEditorValueConverter's | |||
| /// </summary> | |||
| [Obsolete("IPropertyValueConverter is obsolete, but we need to support them until v8, to resolve the correct converter types use: PropertyValueConvertersResolver")] | |||
There was a problem hiding this comment.
Just to be sure, IPropertyEditorValueConverter is obsolete, not IPropertyValueConverter, right?
There was a problem hiding this comment.
IPropertyEditorValueConverter is the obsolete one, whoops, will change the text
…box (since it's like that in the Core one that this overrides), adds new converter for Image cropper including ToString converter & custom type converter to convert from the strongly typed object to JObject, adds test to support this, adds equatable methods for the strongly typed model so it can be easily compared. Ensures that the webboot manager does not include the core value converter for image cropper.
…ws the correct one.
Shazwazza
force-pushed
the
temp-U4-7891
branch
from
96b1802
to
2721c5c
Compare
Shazwazza
added a commit
that referenced
this pull request
Feb 10, 2016
U4-7891 Image Cropper needs a property value converter to return a strongly typed model, json or a string when requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.