Corrected the base URL to use when retrieving and setting public access details. #12178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #12167 as well |
This was
linked to
issues
Mar 25, 2022
|
I think we should revert these changed from a merge conflict (Only the contentResource changes): I'm fairly sure this will resolve the issue.. |
|
I fixed these additional things.. I still think your changes makes sense because that endpoint do not exists on content in v9+. But this is actually less breaking from v8. The alternative would be to remove the functions from the contentResource. |
bergmania
approved these changes
Mar 28, 2022
bergmania
added a commit
that referenced
this pull request
Mar 29, 2022
…ss details. (#12178) * Corrected the base URL to use when retrieving and setting public access details. * Fixed original issue from a merge conflict.. Now using the correct v9+ resource Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 12177, but there may be a little more investigation needed.
This definitely worked in an earlier V9 version as I have it set up in a local test project, and I haven't figured out where the bug crept in. It's also a little odd that we have these methods defined both on the
contentResource(which is being used here), but also on thepublicAccessResource, which isn't.