Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a few more NRT related amends that I found when using these methods in Forms:
GetAll()
onIDataTypeService
to return a non-nullable collection.ClearSessionValue
toISessionManager
(as you can't now set null values).IStatefulNotification
to have null values in the stateTreeControllerBase
. They were introduced here when the asynchronous methods were introduced, but given most Umbraco services and data access is synchronous, in many cases you won't get any benefit using the asynchronous methods, and will add a bit of complexity/noise. So perhaps they should remain valid alternatives, and you choose which you want to use?Also a question... should we have the following in the
.csproj
files? Reason being I had a couple of errors caught by the build server (which I guess must have these options on somehow for when it builds) but that I missed locally.