Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few more NRT tweaks #12323

Merged
merged 9 commits into from May 1, 2022
Merged

Few more NRT tweaks #12323

merged 9 commits into from May 1, 2022

Conversation

AndyButland
Copy link
Contributor

@AndyButland AndyButland commented Apr 29, 2022

Here's a few more NRT related amends that I found when using these methods in Forms:

  • Changed GetAll() on IDataTypeService to return a non-nullable collection.
  • Add a ClearSessionValue to ISessionManager (as you can't now set null values).
  • Allowed an IStatefulNotification to have null values in the state
    • I had a use case for this - needing to log when a form is moved between folders, and if the folder is the root then the value was null. Could work around it (e.g. passing an empty value for null), but seemed it was valid to allow null here.
  • Removed the obsoleting of the synchronous methods in TreeControllerBase. They were introduced here when the asynchronous methods were introduced, but given most Umbraco services and data access is synchronous, in many cases you won't get any benefit using the asynchronous methods, and will add a bit of complexity/noise. So perhaps they should remain valid alternatives, and you choose which you want to use?
  • Aligned nullability of retrieving tree nodes and menus, synchronously or asynchronously (such that we no longer can get null values, always empty collection objects).

Also a question... should we have the following in the .csproj files? Reason being I had a couple of errors caught by the build server (which I guess must have these options on somehow for when it builds) but that I missed locally.

  <Nullable>enable</Nullable>
  <WarningsAsErrors>Nullable</WarningsAsErrors>

@github-actions
Copy link

Hi there @AndyButland, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bergmania bergmania merged commit 96d3320 into v10/dev May 1, 2022
@bergmania bergmania deleted the v10/feature/more-nrt-tweaks branch May 1, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants