Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple words in search U4-2509 #135

Merged
merged 3 commits into from Sep 12, 2013
Merged

Conversation

Myster
Copy link
Contributor

@Myster Myster commented Sep 11, 2013

When multiple words are entered in the search field no results are
returned.
This pull req. contains the fix suggested by Tony.

When multiple words are entered in the search field no results are
returned.
This pull req. contains the fix suggested by Tony.
@Shazwazza
Copy link
Contributor

Do we want GroupedAnd or GroupedOr ? Not sure what makes sense to everyone, obviously grouped-and will require that all words match

- added partial matching on each word.
- fixed bug so 'all' words match rather than 'any' words.
@Myster
Copy link
Contributor Author

Myster commented Sep 12, 2013

ok, the latest commit works nicely how I think it should... but it seems a bit verbose using groupedOr when only one term in one field is searched.

@Shazwazza
Copy link
Contributor

If you think it's the way it should work then I have no problem with that :)

Shazwazza added a commit that referenced this pull request Sep 12, 2013
Fix multiple words in search U4-2509
@Shazwazza Shazwazza merged commit a353f6f into umbraco:master Sep 12, 2013
@Myster Myster deleted the master branch September 12, 2013 03:01
@Myster Myster restored the master branch September 12, 2013 03:02
@Shazwazza
Copy link
Contributor

Oh one thing to note, the GroupedOr was fixed in a recent examine version so you might not even have to do that splitting ....

nul800sebastiaan added a commit that referenced this pull request Feb 20, 2021
…the property type (#9524)

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants