Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support space (and more) in tag groups #13589

Merged
merged 1 commit into from Dec 16, 2022

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Dec 16, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #13146

Description

The linked issue takes a bit of a detour, but here's the gist: If you create a Tags property with a space in the tag group (possibly also other special chars), the Tags editor throws a JS error in the console whenever you focus the editor (click inside the textbox):

image

image

Fortunately this is fixable by replacing all non-word chars in the tags group before putting it to use.

Testing this PR

  1. Create a Tags data type with a space in the tag group.
  2. Create and publish some content with tags using this Tags data type (publish being the magic word here).
  3. Create new content of the same type and verify that the Tags property supports type-ahead using the previously published tags.

tags-with-space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants