Fallback to use ActivatorUtilities to create controller from type, if… #13910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is not registered in DI
bergmania
added
type/bug
release/10.5.0
release/11.3.0
and removed
type/bug
release/10.5.0
release/11.3.0
labels
|
Looks good, tests good 🚀 |
Zeegaan
deleted the
v10/bugfix/13836_fallback_to_ActivatorUtilities_when_creating_controller_from_type
branch
Zeegaan
pushed a commit
that referenced
this pull request
Mar 7, 2023
… it is not registered in DI (#13910)
|
Cherry-picked for 10.5 🍒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13836
Summary
Controllers cannot be resolved from DI if they are not registred. Therefore we have to fall back to use
ActivatorUtilitiesTests
Umbraco.Cms.Web.UI.Composers.ControllersAsServicesComposer. Otherwise this would already have worked.