Added tests for TopoGraph. #14583
Merged
Added tests for TopoGraph. #14583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
We realised there's an implementation of a "directed acyclic graph" in both CMS and Deploy, in the form of the class
TopoGraph. My guess is that at some point it was extracted out of Deploy, tidied up, and used in the CMS - as they are the same other than some formatting and messaging.We plan to obsolete/remote the one in Deploy and use the one in CMS.
However I realised that the tests we have for this in Deploy aren't in CMS, and so rather than removing them added them here so they can continue to verify the behaviour of this class.
To test - just confirm the tests pass.