Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block editors - replaces hardcoded -20 with current node ID #15063

Merged
merged 1 commit into from
Nov 29, 2023

Block editors - replaces hardcoded -20 with current node ID

b6959f6
Select commit
Failed to load commit list.
Merged

Block editors - replaces hardcoded -20 with current node ID #15063

Block editors - replaces hardcoded -20 with current node ID
b6959f6
Select commit
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Oct 30, 2023 in 53s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

Annotations

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/common/services/blockeditormodelobject.service.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 4.32 to 4.41, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
View more details on CodeScene Delta Analysis