V13 RC: Document types throw an error when inserting a block capable editor #15615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrentPageId if we are not in an editor mode we detect the editor mode by checking for `contentTypeKey` which only exists on content contexts
leekelleher
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15588
A minor regression was introduced with #15063 where the
editorStateheld an actual id when used in the Document Type Editor as well, but since this is not real content, the request to GetEmptyByKeys would throw an error whenever you insert any block capable editor on a document type (e.g. rich text editor, block list, and block grid).This has been fixed by checking if we are inside a content editor context or editing a document type by checking for the presence of the property
contentTypeKeyoneditorState.getCurrent(), which should only be present when editing actual content, which has an actual id representing content in the database.