Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Migrate Newtonsoft to System.Text in value converters #15728

Merged
merged 19 commits into from Feb 22, 2024

Conversation

nikolajlauridsen
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen commented Feb 16, 2024

Migrates the value converters to use System.Text.Json instead of Newtonsoft.Json

Additionally, this removes the old JsonNetSerializer since it was a newtonsoft implementation.

This broke some tests because they contained invalid JSON, this is worth being aware of, for the most part there's not much we can do about it, but we may want to consider turning AllowTrailingCommas on in the settings for the SystemTetxJsonSerializer since this may prevent some future issues.

Also removes Nested Content and Grid value converter and so on.

Some classes still have the DataMember attributes, this is because Newtonsoft is still used directly some places, this will be remedied in later PRs

Breaking changes

This PR removes the Newtonsoft implementations of the IJsonSerializer and the contextually aware implementations, this means that Newtonsoft will no longer be used, instead System.Text will, a complete table of differences can be found here.

@bergmania bergmania merged commit 7735552 into v14/dev Feb 22, 2024
15 checks passed
@bergmania bergmania deleted the v14/feature/migrate-property-editors-to-system-text branch February 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants