New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V14: Migrate Newtonsoft to System.Text in value converters #15728
Merged
bergmania
merged 19 commits into
v14/dev
from
v14/feature/migrate-property-editors-to-system-text
Feb 22, 2024
Merged
V14: Migrate Newtonsoft to System.Text in value converters #15728
bergmania
merged 19 commits into
v14/dev
from
v14/feature/migrate-property-editors-to-system-text
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolajlauridsen
added
category/breaking
project/bellissima
AKA "the new backoffice"
labels
Feb 21, 2024
bergmania
reviewed
Feb 22, 2024
bergmania
approved these changes
Feb 22, 2024
bergmania
deleted the
v14/feature/migrate-property-editors-to-system-text
branch
February 22, 2024 10:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the value converters to use
System.Text.Json
instead ofNewtonsoft.Json
Additionally, this removes the old
JsonNetSerializer
since it was a newtonsoft implementation.This broke some tests because they contained invalid JSON, this is worth being aware of, for the most part there's not much we can do about it, but we may want to consider turning
AllowTrailingCommas
on in the settings for theSystemTetxJsonSerializer
since this may prevent some future issues.Also removes Nested Content and Grid value converter and so on.
Some classes still have the
DataMember
attributes, this is because Newtonsoft is still used directly some places, this will be remedied in later PRsBreaking changes
This PR removes the Newtonsoft implementations of the
IJsonSerializer
and the contextually aware implementations, this means that Newtonsoft will no longer be used, insteadSystem.Text
will, a complete table of differences can be found here.